image
image copied to clipboard
image-rs
QOI Support
QOI (Quite OK Image) format is a very niche but interesting image format that competes with PNG. The Rust ecosystem already has crates supporting this format, I decided to use aldanor's implementation as it proved to be the most effective & straight-forward crate to use. This would add encoding + decoding of the format to mainstream image.
How much uptake has QOI had so far? From a quick Google search, I see a couple news articles about the initial release and a bunch of people excited about writing their own implementations in various languages, but no one actually saying they're using it for anything. I'd feel better if we could point to at least a few folks saying they are actually producing/processing images with the format.
The PR itself looks good to me, although I would like to see a direct implementation of ImageDecoder::read_image so we don't end up with an extra copy for that operation (which for a format as fast as QOI is a significant cost!)
I have experimented with using QOI as a format for storing sprites in pixel-art based games. It's pretty promising. As for the errors in my code, my apologies. I'm kinda new to this whole "contributing-to-open-source" thing. I'm not sure how I would go to resolve the 2 pointed out issues in the code. 😅
I'm not sure how I would go to resolve the 2 pointed out issues in the code.
Process wise, you make another commit to your branch wherein the issues are addressed. You push the commit and Github will automatically update the pull request status accordingly. Then we give it another look. No worries about any errors, we do code review and CI because everyone makes those :grinning:
Has this lost steam?
I would be willing to take over and finish this up :)
