dota2compose icon indicating copy to clipboard operation
dota2compose copied to clipboard

Published 20 hours ago • verified publisher icon ilkeraslan

Add PlayersScreen

Open ilkeraslan opened this issue 4 years ago • 4 comments

We should have a Players Screen which is capable of showing professional Dota2 players.

In this task:

  • [ ] This Screen should be integrated into Bottom Navigation like HeroesScreen and TeamsScreen.
  • [ ] The Screen should show the players by their rank in descending order.

The Screen should be built using Jetpack Compose.

This issue is blocked by #4, so you can mock a list of 20 players in a separate file and show that. When #4 is resolved, another issue will be created to integrate the real repository.

ilkeraslan avatar Oct 17 '21 16:10 ilkeraslan

I could take this issue as well.

ahmetkca avatar Oct 17 '22 02:10 ahmetkca

Hey i was wonder if this issue still needs help

erik1906 avatar Apr 14 '23 19:04 erik1906

Hey i was wonder if this issue still needs help

Hey Erik, sure I am assigning this to you. Feel free to ask if you have any questions!

ilkeraslan avatar Apr 28 '23 14:04 ilkeraslan

For the second task

The Screen should show the players by their rank in descending order.

i don't see a good way to do the order, the endpoint GET/proPlayers don't have any rank field and getting another request to see the rank could use a lot of bandwidth

erik1906 avatar May 02 '23 05:05 erik1906