Ivan Levkivskyi
Ivan Levkivskyi
Actually, after thinking more about this it seems to me we are better with _not_ raising by default (and therefore not needing the one-off matches). The point is that this...
> Would you mind sending a PR for our PEP? I can send a PR tomorrow or on weekend (unlikely today).
This issue also affects [mypy](https://github.com/python/mypy), where it probably confuses `mypy.types` with stdlib `types`, see [example](https://lgtm.com/projects/g/python/mypy/snapshot/d1af038f20a1d349e8deb5c4918b844579aed7e7/files/mypy/nodes.py?sort=name&dir=ASC&mode=heatmap#x54d13458663184eb:1) (note there are also some legitimate errors in that and other files, but errors related...
> Do you want to write such benchmark? Yes, I think I can. Just wanted to check if there is interest in such benchmark, IIUC there is.
FWIW the current behavior is intentional, see original PR https://github.com/ilevkivskyi/typing_inspect/pull/78, but maybe the qualified name check is enough. On the added `isinstance(..., type)` will this work for nested `NewType`s? For...
Hm, in principle I would like to keep this tool as simple as possible, but if there is an easy way to add `scopetools` as a dependency to fix this...
Yes, this is a bug. We need to simply reject the type comment.
As I mentioned on the PR https://github.com/typeshed-internal/stub_uploader/pull/59 this introduces a security hole. Having an allowlist in `stub_uploader` (to which intentionally only few maintainers have access) is a possible mitigation, but...
Arbitrary code can be executed during a Python package installation, so if someone adds a malicious package as a dependency, it can cause really big damage, as many of `types-...`...
The risk is that someone my add e.g. `nmupy` as a dependency (whether intentionally or not), so typosquatting, that can't usually harm many people, will now get magnified to some...