Ian Jackson
Ian Jackson
I'm sorry to say that I think this is a bad idea. ### Background Perhaps I should introduce myself. Most relevantly, I was Chief Cryptographer at the HSM manufacturer nCipher;...
The Motivation section discusses things other than images: specifically, scripts. But then the actual proposed new feature only works for images and has a lot of image-specific special casing. Can...
(Workaround MR in derive-deftly is https://gitlab.torproject.org/Diziet/rust-derive-deftly/-/merge_requests/269)
I think at the very least this lint should be downgraded from future-compat before this reaches stable, since we don't want people contorting their code to satisfy it.
References to real-world code that triggered this: crate [tor-persist](https://lib.rs/crates/tor-persist) , pattern introduced in 0.10.1 (2024-03-04). [`impl InstancePurgeHandler for Option
> This is not a false-positive, the `impl` (definition) is non-local, it has an effect outside of the function. See this sample code for a direct proof. How exciting. I...
> If the lint cannot explain itself to @ijackson why it applies, it is a bug. I think it needs to explain not just why it applies, but also suggest...
> It does feel weird but feeling weird isn't enough. I provided a link to a formal specification. The correct prior art to refer to is `getopt_long`, which established the...
Another bug fixed on master: #98
(Hi. I came here via TWIR and [the blog](https://blog.rust-lang.org/inside-rust/2024/05/07/this-development-cycle-in-cargo-1.79.html). I hope this is the right place to put this.) I think the right answer is to require an option to...