algos icon indicating copy to clipboard operation
algos copied to clipboard

Added String Permutation [Python]

Open AnshumanRohella opened this issue 8 years ago • 5 comments

Fixes #581

By submitting this pull request I confirm I've read and complied with the below declarations.

  • [x] I have read the Contribution guidelines and I am confident that my PR reflects them.
  • [x] I have followed the coding guidelines for this project.
  • [x] My code follows the skeleton code structure.
  • [x] This pull request has a descriptive title. For example, Added {Algorithm/DS name} [{Language}], not Update README.md or Added new code.
  • [x] This pull request will be closed if I fail to update it even once in a continuous time span of 7 days.

AnshumanRohella avatar Oct 25 '17 15:10 AnshumanRohella

Hi! Thanks for showing interest in contributing to this repository.

Please make sure that you have ticked the points mentioned in PR description correctly.

Thanks again!

singhpratyush avatar Oct 25 '17 15:10 singhpratyush

Comment on b61424507363b09e38e6104261d5b26af81fdfb5, file string_permutation_problem/permute.py, line 21.

Line contains following spacing inconsistencies:

  • Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: python spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpu5cefre7/string_permutation_problem/permute.py
+++ b/tmp/tmpu5cefre7/string_permutation_problem/permute.py
@@ -18,6 +18,6 @@
 
 def main():
     permute_my_string('abc')
-    
+
 if __name__ == '__main__':
     main()

singhpratyush avatar Oct 25 '17 16:10 singhpratyush

Comment on b61424507363b09e38e6104261d5b26af81fdfb5, file string_permutation_problem/permute.py, line 18.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: pep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpu5cefre7/string_permutation_problem/permute.py
+++ b/tmp/tmpu5cefre7/string_permutation_problem/permute.py
@@ -16,6 +16,7 @@
                 output_string += [letter + perm]
     return output_string
 
+
 def main():
     permute_my_string('abc')
     

singhpratyush avatar Oct 25 '17 16:10 singhpratyush

Comment on b61424507363b09e38e6104261d5b26af81fdfb5, file string_permutation_problem/permute.py, line 21.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: pep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpu5cefre7/string_permutation_problem/permute.py
+++ b/tmp/tmpu5cefre7/string_permutation_problem/permute.py
@@ -18,6 +18,7 @@
 
 def main():
     permute_my_string('abc')
-    
+
+
 if __name__ == '__main__':
     main()

singhpratyush avatar Oct 25 '17 16:10 singhpratyush

ping @AnshumanRohella

aashutoshrathi avatar Dec 30 '17 11:12 aashutoshrathi