ChefLib
ChefLib copied to clipboard
FILLMTR (SEPT17) [Python]
Fixes #189
- [x] Pull Request Title is of form
Problem Code (Contest Code) [Language]. - [ ] This problem already had an entry in this repository.
- [ ] This solution is better than the one already in this repository.
- [x] This solution is prepared by me and not copied from anywhere else on the web.
- [ ] I have added a copyright comment in my solution.
- [x] I have updated README.md file (in appropriate order).
- [x] I have read and followed Code Samples.
- [x] I understand that pull request will be closed if I failed to update it even once in a week.
Hi! Thanks for contributing to this repository. Make sure you have checked points in PR correctly.
Hey, I didn't understand what you posted. I haven't changed any of the files that are shown in the error.
@abhigyank Don't get frightened over such long messages those are auto-generated gitmate issues, from what I can see you need to resolve conflicts and update your repo, thats it. 😉
@Monal5031 please review and merge.
@Monal5031 I request you not to delete, gitmate comments, as it will only raise coala issues.
@aashutoshrathi I don't see travis in the check list, have you deactivated it? Those gitmate messages are very much frightening and discouraging. Also if you know gitmate raises issues on all the commits rather than the latest one, so each time a person updates a commit the same message of gitmate will be raised.
@abhigyank Can make some changes and repush? Inorder to activate the travis build, so we can see what is causing the tests to fail.
@Monal5031 What changes can I make? Maybe you can check the Travis logs or see in the next PR.
@abhigyank You can add spaces around binary operator, like a=b as a = b
@aashutoshrathi Maybe you should squash and merge now.
@abhigyank Sorry for late reply but I can still see three issues in travis log for your PR.
| 26| |- if(i[2]==1):
| | 26|+ if(i[2] == 1):
This one meaning you need to add space around binary opeator on line 26.
_________________________________________________________________
| 64| 64|
| | 65|+
| 65| 66| if __name__ == '__main__':
This one meaning you need to add a blank line before `if __name__ == '__main__':` on line 65.
__________________________________________________________________
| 64| 64|
| 65| 65| if __name__ == '__main__':
| 66| 66| main()
| 67| |-
This one meaning you have extra newline at end.
ping @abhigyank Its been 5 days since this PR was last updated, please update it.
@Monal5031 Check now please.
@aashutoshrathi @Monal5031 All tests passed. Squash and merge PR.
Any reason why this hasn't been merged yet?
@abhigyank Please resolve conflicts