ChefLib icon indicating copy to clipboard operation
ChefLib copied to clipboard

FILLMTR (SEPT17) [Python]

Open abhigyank opened this issue 8 years ago • 16 comments

Fixes #189

  • [x] Pull Request Title is of form Problem Code (Contest Code) [Language].
  • [ ] This problem already had an entry in this repository.
    • [ ] This solution is better than the one already in this repository.
  • [x] This solution is prepared by me and not copied from anywhere else on the web.
  • [ ] I have added a copyright comment in my solution.
  • [x] I have updated README.md file (in appropriate order).
  • [x] I have read and followed Code Samples.
  • [x] I understand that pull request will be closed if I failed to update it even once in a week.

abhigyank avatar Oct 03 '17 10:10 abhigyank

Hi! Thanks for contributing to this repository. Make sure you have checked points in PR correctly.

aashutoshrathi avatar Oct 03 '17 10:10 aashutoshrathi

Hey, I didn't understand what you posted. I haven't changed any of the files that are shown in the error.

abhigyank avatar Oct 03 '17 10:10 abhigyank

@abhigyank Don't get frightened over such long messages those are auto-generated gitmate issues, from what I can see you need to resolve conflicts and update your repo, thats it. 😉

Monal5031 avatar Oct 03 '17 21:10 Monal5031

@Monal5031 please review and merge.

abhigyank avatar Oct 04 '17 05:10 abhigyank

@Monal5031 I request you not to delete, gitmate comments, as it will only raise coala issues.

aashutoshrathi avatar Oct 04 '17 07:10 aashutoshrathi

@aashutoshrathi I don't see travis in the check list, have you deactivated it? Those gitmate messages are very much frightening and discouraging. Also if you know gitmate raises issues on all the commits rather than the latest one, so each time a person updates a commit the same message of gitmate will be raised.

Monal5031 avatar Oct 04 '17 11:10 Monal5031

@abhigyank Can make some changes and repush? Inorder to activate the travis build, so we can see what is causing the tests to fail.

Monal5031 avatar Oct 04 '17 11:10 Monal5031

@Monal5031 What changes can I make? Maybe you can check the Travis logs or see in the next PR.

abhigyank avatar Oct 04 '17 11:10 abhigyank

@abhigyank You can add spaces around binary operator, like a=b as a = b

Monal5031 avatar Oct 04 '17 11:10 Monal5031

@aashutoshrathi Maybe you should squash and merge now.

abhigyank avatar Oct 04 '17 14:10 abhigyank

@abhigyank Sorry for late reply but I can still see three issues in travis log for your PR.


|  26|    |-                    if(i[2]==1):

|    |  26|+                    if(i[2] == 1):

This one meaning you need to add space around binary opeator on line 26.
_________________________________________________________________

|  64|  64| 

|    |  65|+

|  65|  66| if __name__ == '__main__':

This one meaning you need to add a blank line before `if __name__ == '__main__':` on line 65.
__________________________________________________________________
|  64|  64| 

|  65|  65| if __name__ == '__main__':

|  66|  66|     main()

|  67|    |-    

This one meaning you have extra newline at end.

Monal5031 avatar Oct 05 '17 21:10 Monal5031

ping @abhigyank Its been 5 days since this PR was last updated, please update it.

Monal5031 avatar Oct 10 '17 22:10 Monal5031

@Monal5031 Check now please.

abhigyank avatar Oct 13 '17 10:10 abhigyank

@aashutoshrathi @Monal5031 All tests passed. Squash and merge PR.

abhigyank avatar Oct 14 '17 11:10 abhigyank

Any reason why this hasn't been merged yet?

abhigyank avatar Oct 18 '17 20:10 abhigyank

@abhigyank Please resolve conflicts

Monal5031 avatar Oct 30 '17 09:10 Monal5031