esp32-http-server icon indicating copy to clipboard operation
esp32-http-server copied to clipboard

netbuf memory leak

Open FreddySpencer opened this issue 7 years ago • 0 comments

http_handle_connection(): the call netbuf_delete(inbuf) must be moved inside the while loop:

while (ctx->state != HTTP_REQUEST_DONE) {
    err = netconn_recv(conn, &inbuf);
    if (err != ERR_OK) {
        break;
    }

    err = netbuf_data(inbuf, (void**) &buf, &buflen);
    if (err != ERR_OK) {
        break;
    }

    size_t parsed_bytes = http_parser_execute(&ctx->parser, &parser_settings, buf, buflen);
    netbuf_delete(inbuf);
    if (parsed_bytes < buflen) {
        break;
    }
}

FreddySpencer avatar Apr 27 '18 12:04 FreddySpencer