markdownlint-cli icon indicating copy to clipboard operation
markdownlint-cli copied to clipboard

add `--verbose` flag

Open MFTabriz opened this issue 2 years ago • 8 comments

--verbose flag can be used to ensure linter is actually parsing the files when using globs or for general debugging.

PS: ~~I couldn’t think of a simple solution to logs the relevant messages after each file’s name.~~

MFTabriz avatar Jul 31 '23 21:07 MFTabriz

The failing test (failing to parse error message on windows) seems to be unrelated to this PR. It is the same issue which is blocking the dependabot.

MFTabriz avatar Jul 31 '23 21:07 MFTabriz

I think I also fixed the path issue on windows!

MFTabriz avatar Jul 31 '23 21:07 MFTabriz

Do you mind applying that test path fix to the pending Dependabot PR? It should pass after that and I'll accept the PR.

DavidAnson avatar Jul 31 '23 22:07 DavidAnson

Appreciate the tests, BTW!

DavidAnson avatar Jul 31 '23 22:07 DavidAnson

Looks good - tho I can't merge it because it's a Draft PR?

DavidAnson avatar Aug 01 '23 04:08 DavidAnson

Looks good - tho I can't merge it because it's a Draft PR?

Thanks for your quick feedback and helps. I'm trying an idea (and simultaneously learning a bit of JS). I'll finalize this in a couple of days.

MFTabriz avatar Aug 01 '23 20:08 MFTabriz

I'm not sure there's a lot of room to improve upon what you have here, but I will keep an open mind until I see what you're up to. :)

DavidAnson avatar Aug 01 '23 21:08 DavidAnson

@DavidAnson Thanks for keeping an open mind. 😄I hope you are not allergic to bad JS codes!

Now the --verbose flag:

  • logs version
  • logs the list of the files given to the linter and the list of files reported back separately
  • respects --quiet and --output

As you already know, I’m not familiar with idiomatic JS. I’ll appreciate if you can guide me to improve this PR.

MFTabriz avatar Aug 03 '23 19:08 MFTabriz