rustemo icon indicating copy to clipboard operation
rustemo copied to clipboard

Dependency on git binary

Open andrewbaxter opened this issue 11 months ago • 3 comments

Is your feature request related to a problem? Please describe. I'm doing builds in nix and the build environment doesn't have git by default, and I think the git directories too (it might be using an archive tarball). The build fails as is.

Describe the solution you'd like I wouldn't expect this to need git for anything (and I'd like to avoid leaking build environment metadata) - could this be made opt-in?

Describe alternatives you've considered I worked around for now it by setting env var GIT_HASH=fakehash during the build.

andrewbaxter avatar Jan 04 '25 14:01 andrewbaxter

You are right. We should check if git is available and gracefully handle the situation in which it is not.

igordejanovic avatar Jan 05 '25 12:01 igordejanovic

By the way, I'm not sure if I said it before but this is a really cool project! Thanks for working on it. (no rush here, this is more of a convenience thing)

andrewbaxter avatar Jan 05 '25 14:01 andrewbaxter

Thank you for your kind words. I appreciate it!

igordejanovic avatar Jan 05 '25 14:01 igordejanovic