cli
cli copied to clipboard
ignite
Remove the "..." from the events published thought the event bus
Description
Not so long ago we added support to send events thought and event bus with the purpose of having more control on the logging format and output. These changes introduced the spinner to give feedback to the user to wait while the CLI is working. The "..." suffix in the event messages was used before the spinner with the same purpose.
Currently we are using both, there are places in the CLI code that are still adding the "..." suffix which is redundant when the spinner is used.
The "..." suffix could be removed in favor of the spinner animation.
Solution
Remove the "..." suffix from the events sent thought the event bus.
Don't add "..." suffix to events that are printed within the spinner.
I would concur that removing the ... would be ideal since we have the spinner that communicates the same thing and the spinner itself is more reassuring that "it's working" than just a static .... Nice suggestion @jeronimoalbi!
My two cents is that it looks nicer with the spinner and the ....
If we remove them, it looks like something is missing.
