cli icon indicating copy to clipboard operation
cli copied to clipboard

chore: create openapiconsole sub module

Open tbruyelle opened this issue 3 years ago • 4 comments

Part of #2658

This is the first step of releasing openapiconsole as a separate go module inside the cli repository, which consists of:

  • adding a go.mod in ignite/pkg/openapiconsole/ folder
  • declaring openapiconsole dep in the main go.mod (because it's currently used by pkg/cosmosfaucet)

The second step, once this PR is merged, is to push a specific tag for this new module, which must look like ignite/pkg/openapiconsole/v1.0.0 (I think using v1 is OK for such a small module).

One the tag exists, a second PR will remove the replace directive and change the dep version for this tag.

tbruyelle avatar Sep 19 '22 15:09 tbruyelle

@ilgooz what do you think?

aljo242 avatar Sep 19 '22 15:09 aljo242

For consistency I would recommend to follow semver even for small packages. Also to avoid any unexpected issues with the go tooling.

jeronimoalbi avatar Sep 19 '22 15:09 jeronimoalbi

For consistency I would recommend to follow semver even for small packages. Also to avoid any unexpected issues with the go tooling.

good point, the tag should be ignite/pkg/openapiconsole/v1.0.0 (the prefix is mandatory for go mod to work with sub modules)

tbruyelle avatar Sep 19 '22 15:09 tbruyelle

We could maybe think in the future of a sub-module that groups all the packages aimed to be imported as it would be easier to manage releases but I think it's okay if we have less than 5 packages

With #2803 , openapiconsole will be the only imported package, the PR removes cosmoscmd and cosmosibckeeper.

tbruyelle avatar Sep 20 '22 09:09 tbruyelle