solargraph-rails icon indicating copy to clipboard operation
solargraph-rails copied to clipboard

Permit newer Solargraph versions

Open jaredcwhite opened this issue 3 years ago • 3 comments
trafficstars

This just updates the Solargraph dependency in the gemspec to 0.45 with the ability to update to 0.46, etc. I haven't done an extensive test but it seems to be working fine in my project.

jaredcwhite avatar Sep 09 '22 22:09 jaredcwhite

Hmm, just saw this issue with loading find on an association:

Message: [Solargraph::ComplexTypeError] Unclosed subtype in ActiveRecord::Associations::CollectionProxy

Not sure if that's due to the version bump or just some other thing.

jaredcwhite avatar Sep 09 '22 22:09 jaredcwhite

@jaredcwhite that sounds like https://github.com/castwide/solargraph/issues/589, which has been fixed but I don't think it's in a release yet

grncdr avatar Sep 12 '22 15:09 grncdr

The fix seems to have been released in 0.47.0. #47 is a duplicate of this. I wanted to try this gem and was confused when some of the features were not working as advertised, but it installed the old version 0.3.1 because of the version of solargraph I already have in my lockfile.

#43 also increments the solargraph version, but still includes a patch number. I guess solargraph doesn't provide a stable api to hook into, and this is required so it doesn't break all the time?

Earlopain avatar Oct 19 '22 07:10 Earlopain

@jaredcwhite please do a pull from master so that CI runs properly

alisnic avatar Nov 02 '22 12:11 alisnic

Might be good to close this now that https://github.com/iftheshoefritz/solargraph-rails/pull/49 has landed which essentially fixes this issue.

gwillcox-r7 avatar Dec 08 '22 19:12 gwillcox-r7