SharpZipLib icon indicating copy to clipboard operation
SharpZipLib copied to clipboard

Add net462 targeting

Open lahma opened this issue 1 year ago • 2 comments

It's not that much of a maintenance burden and will remove some compatibility issues for folks still on full framework. SharpZipLib 2.0 could drop support if deemed so.

Also had to update testing dependencies to get NET 8 support.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

fixes #853 fixes #863

lahma avatar Jul 18 '24 16:07 lahma

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.62%. Comparing base (c51ef18) to head (2255a47). Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
- Coverage   74.78%   74.62%   -0.16%     
==========================================
  Files          72       75       +3     
  Lines        8535     8572      +37     
==========================================
+ Hits         6383     6397      +14     
- Misses       2152     2175      +23     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 19 '24 07:07 codecov[bot]

@piksel can you please take a look, this PR should fix GH Actions pipelines and adds the requested net462 target which should be quite safe addition.

lahma avatar Jul 19 '24 07:07 lahma