RefactoringEssentials
RefactoringEssentials copied to clipboard
Wrong fix on RECS0063 with StartsWith
trafficstars
Having this code:
query.StartsWith("select", true, CultureInfo.InvariantCulture)
RefactoringEssentials will pop a RECS0063, despite the fact that we are using Invariant Culture.
When using the fix provided, the code be will be changed to
query.StartsWith("select", true, CultureInfo.InvariantCulture, StringComparison.Ordinal)
which is not a valid call of StartsWith:
public bool StartsWith(String value, StringComparison comparisonType);
public bool StartsWith(String value, bool ignoreCase, CultureInfo culture);
public bool StartsWith(String value);
We should either detect that we don't need the refactoring as we are already using InvariantCulture or switch to the String comparison version of the method.