AvaloniaILSpy icon indicating copy to clipboard operation
AvaloniaILSpy copied to clipboard

Published 20 hours ago • verified publisher icon icsharpcode

Update syntax highlighting and fixed opaque text marking

Open DamianSuess opened this issue 2 years ago • 5 comments

Feature includes:

  • Added EditorConfig file to ensure Visual Studio settings match the project's unique preferences
  • Updated syntax highlighting rules to match those in the latest ILSpy
  • Added ILAsm-Mode-Dark.xshd style definition
  • Added display setting, Highlight Current Line

Before

image

After

image

DamianSuess avatar Feb 02 '23 18:02 DamianSuess

ha! silly me, just noticed the other ILSpy repo had an editorconfig. Replaced my implementation w/ the one you're using ;)

DamianSuess avatar Feb 02 '23 19:02 DamianSuess

Please let me know if there is anything else needed. Overall, I'd like to see a ThemeManager for the resource dictionaries so that the Dark/Light themes can be properly managed, thus unifying the projects a bit better. I figured that was a bit out of scope here without asking permission first.

DamianSuess avatar Feb 02 '23 21:02 DamianSuess

The latest check-in addresses an existing issue where the TextMarker's background box hides the selected text. The box is being drawn in TextMarkerService.Draw(..) on Line 118.

As a short workaround, I provided a semi-transparent color. Considering that the same code is being used for the WPF TextMarkerService and even the sample project, I'm guessing this may be an issue w/ AvaloniaEdit?

DamianSuess avatar Feb 02 '23 21:02 DamianSuess

Lastly, here is a sample screenshot of the improved text selection and text marking

Before:

SelectionAndTextMarking--Before

After:

SelectionAndTextMarking

DamianSuess avatar Feb 03 '23 15:02 DamianSuess

Any thoughts on this PR? Let me know of any suggested changes

DamianSuess avatar May 04 '23 15:05 DamianSuess