iced icon indicating copy to clipboard operation
iced copied to clipboard

custom command feature missing in 0.13

Open Decodetalkers opened this issue 1 year ago • 3 comments

Is your issue REALLY a bug?

  • [X] My issue is indeed a bug!
  • [X] I am not crazy! I will not fill out this form just to ask a question or request a feature. Pinky promise.

Is there an existing issue for this?

  • [X] I have searched the existing issues.

Is this issue related to iced?

  • [X] My hardware is compatible and my graphics drivers are up-to-date.

What happened?

In month, I make a pr in https://github.com/iced-rs/iced/pull/2146/. This pr allow to add extra action passed to iced, it is merged, and we develop https://github.com/waycrate/exwlshelleventloop this project. but now I find this feature is missing in new iced..

What is the expected behavior?

Can you help keep the feature? it is important to our program

Version

master

Operating System

macOS

Do you have any log output?

No response

Decodetalkers avatar Aug 07 '24 13:08 Decodetalkers

I find the structure of iced is changed, not it cannot simply add a Box<dyn Any> into actions..

Decodetalkers avatar Aug 07 '24 13:08 Decodetalkers

Ok.. maybe I can use Action::Output<T>, and Strict T to have try_into() trait.. can be try_into my custom actions

the breaking change in 0.13 is too much.. I am afraid I cannot follow the changes

Decodetalkers avatar Aug 07 '24 13:08 Decodetalkers

Regarding the breaking changes: I think this is to be expected with software that is still in active development. The maintainers of iced have warned us at several instances that breaking changes are likely.

I, for one, do want breaking changes at this moment in time, since this allows the maintainers to experiment and to find an api that makes sense. It is better for the project in the long run.

To help you out, while I have no experience working with Commands, I think that the struct you are looking for is now located at iced::Task.

jdbosser avatar Aug 09 '24 14:08 jdbosser

It would be a good idea to start including breaking changes in the change-logs like renaming of Command to Task.

DaRacci avatar Oct 08 '24 03:10 DaRacci

Ok , this is not a problem for me anymore.. ok, I will close this issue

Decodetalkers avatar Oct 08 '24 03:10 Decodetalkers