resilient-python-api icon indicating copy to clipboard operation
resilient-python-api copied to clipboard

NoneType Error Handling Reversed

Open elf32 opened this issue 6 years ago • 0 comments

I wasn't sure where to place issues related to the resilient-circuits framework itself, if there is a more appropriate place please let me know.

During some test building of functions and components, if a cafile path is found to be None, for whatever reason (originating from line 468), and is passed into the _setup_stomp function; the call will fail on line 469, seen below. None types don't have attributes to call .strip() or .lower(). https://github.com/ibmresilient/resilient-python-api/blob/ad42daa696ab6d7c1122bedc7532b8546e8aa05d/resilient-circuits/resilient_circuits/actions_component.py#L469

The code appeared to anticipate a possible None type being received, since line 473 does a check for this. https://github.com/ibmresilient/resilient-python-api/blob/ad42daa696ab6d7c1122bedc7532b8546e8aa05d/resilient-circuits/resilient_circuits/actions_component.py#L473

These should probably be swapped to handle the None value being received before working through the other cases.

elf32 avatar Jul 24 '19 22:07 elf32