Rename some GitHubCity's properties

[iblancasa]

trafficstars

Some properties from GitHubCity need a new name:

• __names → __usersToProccess
• __myusers → __cityUsers
• __dataUsers → __processedUsers
• __fin → __ended
• __excluded → __excludedUsers

This will help to make easier to understand the code and document it.

[aaronmaynard]

:art: This is simply combing through the files and exchanging variable names in the src/githubcity folder? I would like to tackle this. Also, does this include the non __* ones? Such as: dataUsers = self.getSortedUsers(sort) and if limit: dataUsers = dataUsers[:limit]

[ci skip]

[iblancasa]

Hi! Yes, it is only to rename the variables.

I chose a bad name for the variable __dataUsers. Also, I called a variable as dataUsers in the __exportUsers method.

Actually, __dataUsers and dataUsers are different variables (for this reason I want to rename __dataUsers to __processedUsers). They are different because I want to save all the processed users in __processedUsers (without limit). I use dataUsers the limit first users.

This is so nice!

if limit: dataUsers = dataUsers[:limit]

Thank you! :+1:

[aaronmaynard]

@iblancasa completed