ibis
ibis copied to clipboard
style: reformat to the Black default line length of 88
This PR changes the line length of the codebase to the black default of 88
Codecov Report
Merging #4517 (d1931b2) into master (39cea3b) will decrease coverage by
0.38%. The diff coverage is88.65%.
@@ Coverage Diff @@
## master #4517 +/- ##
==========================================
- Coverage 92.38% 91.99% -0.39%
==========================================
Files 189 189
Lines 20661 20661
Branches 2855 2855
==========================================
- Hits 19087 19007 -80
- Misses 1181 1261 +80
Partials 393 393
| Impacted Files | Coverage Δ | |
|---|---|---|
| ibis/backends/dask/core.py | 94.59% <0.00%> (ø) |
|
| ibis/backends/dask/execution/aggregations.py | 81.35% <ø> (ø) |
|
| ibis/backends/dask/execution/arrays.py | 95.23% <ø> (ø) |
|
| ibis/backends/dask/udf.py | 97.39% <0.00%> (ø) |
|
| ibis/backends/duckdb/datatypes.py | 100.00% <ø> (ø) |
|
| ibis/backends/mysql/datatypes.py | 92.45% <ø> (ø) |
|
| ibis/backends/pandas/execution/timecontext.py | 81.81% <ø> (ø) |
|
| ibis/backends/postgres/__init__.py | 100.00% <ø> (ø) |
|
| ibis/backends/pyspark/timecontext.py | 90.00% <ø> (ø) |
|
| ibis/backends/snowflake/__init__.py | 44.26% <0.00%> (-44.27%) |
:arrow_down: |
| ... and 123 more |
Test Results
35 files 35 suites 1h 26m 26s :stopwatch: 10 101 tests 7 923 :heavy_check_mark: 2 178 :zzz: 0 :x: 36 861 runs 28 483 :heavy_check_mark: 8 378 :zzz: 0 :x:
Results for commit d1931b2f.
:recycle: This comment has been updated with latest results.
Strangely github doesn't crosslink discussions here. See the relevant thread at https://github.com/ibis-project/ibis/discussions/4515
Based on the discussion in #4515, it looks like a line length of 88 is preferred, matching what's done here. Is there anything left to do here?
We need to rerun the formatter on the current main branch, also we should add the created formatting commit to .git-blame-ignore-revs
@kszucs Are you opposed to this change?
@kszucs Are you opposed to this change?
Nope, I don't have a strong opinion on this.
@kszucs Shall we merge? I'll add the commit to the ignore revs file once it lands upstream.