vat icon indicating copy to clipboard operation
vat copied to clipboard

Published 20 hours ago • verified publisher icon ibericode

Add exceptions rates support

Open trippo opened this issue 2 years ago • 6 comments

trippo avatar Sep 21 '23 15:09 trippo

Hi @trippo I would recommend to split the PR, you're trying to do 2 things here:

  • Adding exceptions rates supports
  • Removing the GB VAT number validations.

The second one is a breaking change

VincentLanglet avatar Nov 14 '23 16:11 VincentLanglet

Re-added GB validator

trippo avatar Nov 14 '23 16:11 trippo

@VincentLanglet please review

trippo avatar Nov 15 '23 14:11 trippo

@VincentLanglet please review

I'm not the maintainer, I cannot

  • launch github actions
  • approve
  • merge

VincentLanglet avatar Nov 15 '23 15:11 VincentLanglet

(But I would recommend you to open two separate PR: One with https://github.com/ibericode/vat/pull/61/commits/84d6002ab74eec8af5fb72148376b76724c0ef01 and one with https://github.com/ibericode/vat/pull/61/commits/e5014d7f16ca8a2daa9b3a26d103ef43c6b959f9)

VincentLanglet avatar Nov 22 '23 11:11 VincentLanglet

Hello @trippo,

I'm the maintainer yet I wholeheartedly agree with @VincentLanglet - unfortunately there are so many changes in this PR targeting several separate things that it's really hard for me to confirm what is changing and whether this is safe to merge in the codebase.

Separate PR's would be super helpful in making this a little easier for me.

dannyvankooten avatar Nov 23 '23 19:11 dannyvankooten