vat icon indicating copy to clipboard operation
vat copied to clipboard

Update Validator.php

Open karol-may opened this issue 3 years ago • 1 comments

Adding Weighted Checksum Check i.e. for polish VAT ID

karol-may avatar Jul 31 '22 13:07 karol-may

Hello @karol-may,

Nice work! Thank you for submitting as a PR. I have two questions though:

  • Where can I find some documentation (by the Polish government, preferably) on this behavior? Do all Polish VAT number match this format?
  • Can you add some tests for this, eg one for a VAT number without a weighed checksum (any non PL number as of now), one for a Polish VAT number that doesn't match and one valid one?

dannyvankooten avatar Aug 03 '22 08:08 dannyvankooten

Closing because of inactivity, but in case you're keen to get merged just let me know and we can pick up where we left.

dannyvankooten avatar Nov 23 '23 19:11 dannyvankooten