Amethyst icon indicating copy to clipboard operation
Amethyst copied to clipboard

3column-middle label seems to be unrecognized

Open izosozi opened this issue 11 months ago • 1 comments

Describe the bug

The layout name 3column-middle seems to be unrecognized. The README states:

3Column-Middle

Exactly like 3Column-Left, but the main pane is in the middle, with the other panes on either side. (In previous versions of Amethyst, this layout was known as Middle-Wide.)

and the sample config file includes the comment:

# - middle-wide # The legacy name of "3column-middle"

These imply that middle-wide is not the correct name in the newest stable version of Amethyst (0.21.2), but in fact only middle-wide works as expected, and 3column-middle does not.

To Reproduce

  1. Include - 3column-middle in layouts: in the amethyst.yaml file.
  2. Create a shortcut for select-3column-middle-layout
  3. Reload Amethyst and trigger the shortcut

Expected behavior

The 3Column-Middle layout should be selected

Actual behavior

Nothing happens

Versions:

  • macOS 15.1.1 (24B91)
  • Amethyst: 0.21.2 (112)

Debug Info

Version: 0.21.2 (112)

OS version: Version 15.1.1 (Build 24B91)

Screens:
	(0.0, 0.0, 1710.0, 1112.0) [(0.0, 0.0, 1710.0, 1112.0)]

Configuration:
screen-padding-top: 0
window-margin-size: 0
window-minimum-width: 0
mouse-follows-focus: 0
disable-padding-on-builtin-display: 0
smart-window-margins: 0
window-minimum-height: 0
window-margins: 0
mod1: (
    option,
    shift,
    control,
    command
)
floating: (
)
follow-space-thrown-windows: 1
debug-layout-info: 0
floating-is-blacklist: 1
screen-padding-left: 0
window-max-count: 0
focus-follows-mouse: 0
new-windows-to-main: 0
layouts: (
    fullscreen,
    "two-pane",
    "3column-middle",
    floating,
    bsp
)
mod2: (
    option,
    control
)
ignore-menu-bar: 0
enables-layout-hud: 1
enables-layout-hud-on-space-change: 1
use-canary-build: 0
restore-layouts-on-launch: 1
screen-padding-right: 0
screen-padding-bottom: 0
float-small-windows: 0
hide-menu-bar-icon: 0
mouse-swaps-windows: 0
window-resize-step: 5
mouse-resizes-windows: 1

Thanks!

izosozi avatar Dec 25 '24 07:12 izosozi

Legacy in that case refers to the fact that the variations didn't exist when the key was defined. It's still the correct key, but it's easy enough to add the new one as an alias.

ianyh avatar Jan 25 '25 12:01 ianyh