slate-plugins icon indicating copy to clipboard operation
slate-plugins copied to clipboard

slate-drop-or-paste-images: Error is thrown if file has no extension

Open tommoor opened this issue 6 years ago • 1 comments

Do you want to request a feature or report a bug?

Bug 🐛

What's the current behavior?

  • Create a file with no extension
  • Drag and drop into editor
  • A JS error is thrown: Uncaught TypeError: Cannot read property 'includes' of undefined

What's the expected behavior?

  • The plugin accounts for this type of file

tommoor avatar Feb 16 '19 04:02 tommoor

The problem is that ext can become undefined at https://github.com/ianstormtaylor/slate-plugins/blob/d057c71e94a9396eba76a4c50d9d0cd840e8b1e9/packages/slate-drop-or-paste-images/src/index.js#L109

But that code is bad anyway, it won't handle .foo.jpg or bar.old.jpg. Better to use a regex like /([^.]+)$/.exec(name)

wmertens avatar Mar 13 '19 14:03 wmertens