Results 81 comments of Ralph Thomas

Oops — yes, I requested reviews too soon and then changed to WIP once I saw more failures than I could fix last night… I will move it to Draft...

It took me quite a long time to figure out where the changes were coming from. There were two sources: - Our text measurement function would sometimes return a large...

Code change LGTM, and I think the test changes are good, but I only manually checked the Design Switcher rendering (the "SYNC STATUS" text has moved down, which matches the...

We don't have this currently -- for your implementation would it be within a single list, or between multiple lists in the same app, or between apps?

That's correct -- we'd recommend using variants at the root layer to achieve RHD and RTL, because automatic mirroring doesn't get the right result in cars. Would this work for...

I think we can take this on as a customization feature - as a workaround for now, you can add a `Modifier` tappable customization that handles the long press event....

I thought that the video example worked OK, and we're showing maps in DriverUI (via `AndroidView` wrapping a `SurfaceView` or something similar). Does one of the tests fail on this...

The objects are already scaled based on DPI, if you want to scale them more then you can use a Compose scale modifier outside of the Composable generated by DesignCompose.

[I had a go at text path support](https://github.com/google/automotive-design-compose/commit/62da8cb2da4c29af40ca49289f18e7d546827d54), but unfortunately got blocked by issues with Figma's API implementation (meaning that it's not possible to do an end-to-end implementation yet).

What's missing for API35 support?