TheNodeCourse icon indicating copy to clipboard operation
TheNodeCourse copied to clipboard

Course Suggestions

Open iampavangandhi opened this issue 5 years ago • 8 comments
trafficstars

Hello @everyone :wave:,

You can tell your thoughts and suggestions related to TheNodeCourse here.

Pavan Gandhi (Mentor)

iampavangandhi avatar Jul 19 '20 13:07 iampavangandhi

Hey, @iampavangandhi

Please check Below the mentioned Automated Bots Below. it will be the perfect use for our Project.

  • [x] Hound (Automatic Code Review)
  • [x] ImgBot (Automatic Optimizes Image)
  • [x] Codacy (Automated code review)

howdyAnkit avatar Jul 29 '20 13:07 howdyAnkit

Hey, @howdyAnkit

Thanks for the suggestions we don't need these automated bots in TheNodeCourse Project because I and @vectorrb are the only contributors. We will surely use these bots in TradeByte as it's a team project.

iampavangandhi avatar Jul 29 '20 13:07 iampavangandhi

Hey @iampavangandhi I have a course suggestion of having a tutorial of bcrypt in TheNodeCourse as its widely used in hashing the credentials and then using it in storing the data in MongoDB. I would like to work on this as I'm pretty familiar with NodeJs.

ChiragBolakani avatar Oct 15 '20 13:10 ChiragBolakani

@ChiragBolakani Yes, you can try. you also have to create a .md file where you explain all about bcrypt and your code in a code folder then add both of them in a folder Auth Topic 6 and add it in the 04 Auth and Database folder

Note: You don't have to do any linking. I will do that myself after merging the PR

iampavangandhi avatar Oct 15 '20 14:10 iampavangandhi

@iampavangandhi I have started working on it.

ChiragBolakani avatar Oct 15 '20 15:10 ChiragBolakani

@iampavangandhi I have completed the task. This is my pull request #38

ChiragBolakani avatar Oct 25 '20 17:10 ChiragBolakani

@ChiragBolakani PR Merged 🎉 Welcome to TheNodeCourse 👍🏻

iampavangandhi avatar Oct 25 '20 17:10 iampavangandhi

@iampavangandhi Please add the hacktoberfest label again to the repo. My pull request was not counted as the repo didn't had hacktoberfest label. The hacktoberfest also has a 14 days review period and the pull request needs to pass that. You may remove the hacktoberfest label after 10 November. Thank you.

ChiragBolakani avatar Nov 01 '20 12:11 ChiragBolakani