dayjs icon indicating copy to clipboard operation
dayjs copied to clipboard

added Palestinian locale with Syriac month names

Open majdal opened this issue 6 years ago • 6 comments

Hello!

Just adding a new local that has Syriac month names, used in Palestine, Lebanon, Syria, Jordan, and Iraq (see).

majdal avatar Aug 06 '19 16:08 majdal

Codecov Report

Merging #654 into dev will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #654      +/-   ##
==========================================
+ Coverage   99.89%   99.89%   +<.01%     
==========================================
  Files         154      155       +1     
  Lines         989      992       +3     
  Branches      148      148              
==========================================
+ Hits          988      991       +3     
  Misses          1        1
Impacted Files Coverage Δ
src/locale/ar-ps.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95e70b4...71193b5. Read the comment docs.

codecov-io avatar Aug 06 '19 16:08 codecov-io

Thanks.

On question here, why can't I find the same locale name in https://github.com/moment/moment/tree/develop/src/locale ?

iamkun avatar Aug 06 '19 17:08 iamkun

Welcome!

There are 22 Arabic-speaking counties in the world, only 6 of them have a locale specified in the moment.js repo. I'll create a pull request for that repo too.

majdal avatar Aug 07 '19 08:08 majdal

@majdal I see. Thanks for the explanation. This repo is intended to keep the same with moment.js. And I'll merge this PR as soon as the related pr is merged in moment.js repo.

iamkun avatar Aug 07 '19 08:08 iamkun

Alright, submitted.

majdal avatar Aug 07 '19 08:08 majdal

Waiting for native speaker review ( 0 / 2 )

iamkun avatar Oct 02 '20 15:10 iamkun