dayjs
dayjs copied to clipboard
added Palestinian locale with Syriac month names
Hello!
Just adding a new local that has Syriac month names, used in Palestine, Lebanon, Syria, Jordan, and Iraq (see).
Codecov Report
Merging #654 into dev will increase coverage by
<.01%. The diff coverage is100%.
@@ Coverage Diff @@
## dev #654 +/- ##
==========================================
+ Coverage 99.89% 99.89% +<.01%
==========================================
Files 154 155 +1
Lines 989 992 +3
Branches 148 148
==========================================
+ Hits 988 991 +3
Misses 1 1
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/locale/ar-ps.js | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 95e70b4...71193b5. Read the comment docs.
Thanks.
On question here, why can't I find the same locale name in https://github.com/moment/moment/tree/develop/src/locale ?
Welcome!
There are 22 Arabic-speaking counties in the world, only 6 of them have a locale specified in the moment.js repo. I'll create a pull request for that repo too.
@majdal I see. Thanks for the explanation. This repo is intended to keep the same with moment.js. And I'll merge this PR as soon as the related pr is merged in moment.js repo.
Alright, submitted.
Waiting for native speaker review ( 0 / 2 )