Eric Davies
Eric Davies
I was missing the method `+(::Nabla.Branch{Array{Float64,2}}, ::Diagonal{Nabla.Branch{Float64}})`
Would it? Or would it just be sufficient to include https://github.com/JuliaMath/AbstractFFTs.jl?
LGTM but needs tests
I would guess it needs to work something like this instead: https://github.com/JuliaLang/IJulia.jl/pull/671/files#diff-54090e4bd9da3cc6b0fbb839b246aeb3R120-R121 and temporarily set the `global_logger` to a SimpleLogger pointing to the redirected stderr.
If we want to continue to support 0.4 I'll make an additional test file for 0.5+ tests that use generator syntax.
Alright, I have a few improvements. PR coming soon. I haven't beat Python, but I've come within a more acceptable margin.
The reason the Python code is so fast is it uses the reference counter directly to reclaim memory in cases where the item generated is used and then discarded (a...
~The `Cholesky` constructor does still check positive definiteness~ nvm, only true for Julia 0.6
> Maybe the same error as in [invenia/KeyedDistributions.jl#24](https://github.com/invenia/KeyedDistributions.jl/issues/24)? Seems likely; this error also does not happen on Julia 1.7.
One possibility is to have functions always return iterators when called on iterator objects, and provide a function (e.g., `iter`) that converts collections to iterators.