lib_autolink icon indicating copy to clipboard operation
lib_autolink copied to clipboard

convert foo.com

Open lsmith77 opened this issue 11 years ago • 4 comments
trafficstars

imho it would make sense to also convert test.com type strings

1) Liip\UrlAutoConverterBundle\Tests\Extension\UrlAutoConverterTwigExtensionTest::testAutoConvertUrls with data set #1 ('Lorem ipsum dolor sit amet, <a href="http://test.com">test.com</a> consectetuer adipiscing', 'Lorem ipsum dolor sit amet, test.com consectetuer adipiscing')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, <a href="http://test.com">test.com</a> consectetuer adipiscing'
+'Lorem ipsum dolor sit amet, test.com consectetuer adipiscing'
1) Liip\UrlAutoConverterBundle\Tests\Extension\UrlAutoConverterTwigExtensionTest::testAutoConvertUrls with data set #3 ('Lorem ipsum dolor sit amet, lala <a href="http://subtest.test.com">subtest.test.com</a> aksjdhasd.', 'Lorem ipsum dolor sit amet, lala subtest.test.com aksjdhasd.')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, lala <a href="http://subtest.test.com">subtest.test.com</a> aksjdhasd.'
+'Lorem ipsum dolor sit amet, lala subtest.test.com aksjdhasd.'

lsmith77 avatar Nov 28 '13 09:11 lsmith77

+1 on this. If not default we could turn this feature on with some flags.

prionkor avatar Feb 10 '14 05:02 prionkor

ping

dbu avatar May 06 '14 06:05 dbu

feel free to send a pull request

doing this gets complicated - what TLDs do you support? do some TLDs requires paths? (else the perl script foo.pl is suddenly a URL)

iamcal avatar May 07 '14 00:05 iamcal

That list is called the "public suffix list" and can be found at https://publicsuffix.org/

cweiske avatar Jan 11 '21 14:01 cweiske