inbox-react-intl icon indicating copy to clipboard operation
inbox-react-intl copied to clipboard

code comment inconsistency

Open ruffle1986 opened this issue 7 years ago • 0 comments

First of all, let me tell you how much I appreciate your article and the sample project on localizing react projects. It was very helpful to make decisions in case of one of my projects to make it available worldwide.

https://github.com/iam-peekay/inbox-react-intl/blob/master/src/js/index.js#L23-L24

While I was looking at your code, I noted that this particular line of code (see above) doesn't do what the comment says in the previous line. It says Try full locale first but you're trying to get the messages by providing the locale code without the region code first.

Since the locale code with the region (full locale code) is more specific, it's better to try it first. So the comment is correct and the code above is supposed to work according to that.

ruffle1986 avatar Jan 10 '18 10:01 ruffle1986