ObjectiveRocks icon indicating copy to clipboard operation
ObjectiveRocks copied to clipboard

Published 20 hours ago • verified publisher icon iabudiab

Improve RocksDB interface

Open jurmous opened this issue 6 years ago • 4 comments

  • Add keyMayExist methods
  • Add file deletion methods
  • Add background work pause and continue methods
  • Fix spelling mistakes

jurmous avatar Oct 22 '19 18:10 jurmous

Hey @jurmous, I'll take a look at this tomorrow evening and will release a new version after the pull. I left a small feedback there in regards to the API, let's discuss it tomorrow in more detail. Thanks again for all the PRs!

iabudiab avatar Oct 22 '19 22:10 iabudiab

I don't see the feedback? Where can it be found?

Probably I would like to expand this PR to add more methods to the RocksDB interface. Could also be a separate PR. Maybe it is good to wait a bit for a release so more methods can be added. I am still playing around to use this library as the iOS/Mac interface into a RocksDB Kotlin multiplatform module.

Thanks for merging the others! And all the work in creating this library! 😄

jurmous avatar Oct 23 '19 15:10 jurmous

I don't see the feedback? Where can it be found?

Sorry my bad, I totally forgot about the new way GitHub starts reviews. I forgot to submit it.

iabudiab avatar Oct 23 '19 20:10 iabudiab

If you want to expand upon this PR or open a new one, it would be much appreciated 😉

iabudiab avatar Oct 23 '19 20:10 iabudiab