Conversations icon indicating copy to clipboard operation
Conversations copied to clipboard

Upside down video calls

Open buggymonkey opened this issue 5 years ago • 23 comments
trafficstars

General information

  • Version: 2.8.8+fcr
  • Device: Fairphone 2
  • Android Version: LineageOS 17.1 without google things
  • Server name: self hosted
  • Server software: ejabberd
  • Conversations source: F-Droid

Steps to reproduce

  1. make a video call

Expected result

What is the expected output? The video of the front cameras should be shown in correct orientation

Actual result

What do you see instead? The video of my front camera is upside down. The video of the other person is oriented correctly. So this might be a Fairphone 2 problem. However, other apps have the front camera oriented correctly.

Thanks for all the effort you spent in this project :heart:

buggymonkey avatar Jul 18 '20 10:07 buggymonkey

I have the same problem, also on an FP2 with google-free LineageOS 17.1 (from 24 July) and Conversations 2.8.9+fcr.

The orientation of the front camera is correct in other apps, including the stock camera, OpenCamera, Nextcloud Talk and Firefox.

Edit: I remember calling someone else with the stock Google Android version on FP2 and their video was oriented correctly, so this seems to be LineageOS specific.

Edit 2: Sorry for not mentioning this, I am also on FP2.

m4lvin avatar Jul 29 '20 09:07 m4lvin

Please include your device in any 'me too' style bug reports.

iNPUTmice avatar Jul 29 '20 09:07 iNPUTmice

Does it show up correctly on the recipient's end?

iNPUTmice avatar Jul 29 '20 10:07 iNPUTmice

Does it show up correctly on the recipient's end?

No. The video is upside down both on my own FP2 and on the phone of the person receiving the call (no matter if it is an FP2 or not).

m4lvin avatar Jul 29 '20 10:07 m4lvin

This seems to be device specific and this will probably take someone with access to the device to fix it for themselves.

The good news is that all webrtc code is wrapped in just one class https://github.com/iNPUTmice/Conversations/blob/master/src/main/java/eu/siacs/conversations/xmpp/jingle/WebRTCWrapper.java

Someone probably needs to apply some 180 degree 'correction' to the camera capturer. But only on FP2 devices. And the test all that properly for rotating the device and for front and back camera.

iNPUTmice avatar Jul 29 '20 10:07 iNPUTmice

One more parameter: The FP2 comes with different front camera modules: the original had 2MP, the new module has 5MP [1]. Maybe the problem only occurs with the new one (which I am using). @buggymonkey which front camera module do you have?

I also started a topic here https://forum.fairphone.com/t/front-camera-video-upside-down-in-conversations-video-calls/63110

[1] https://shop.fairphone.com/en/fairphone-2-top-module

m4lvin avatar Jul 29 '20 12:07 m4lvin

I also use the new front camera (5MP).

I took a rough look at the WebRTCWrapper file. But i failed to find a proper documentation for the org.webrtc stuff. Is there any?

I could also test things on my device.

buggymonkey avatar Jul 29 '20 12:07 buggymonkey

Reading up on the on Fairphone forum thread it seems that there are Fairphone 2s with and without the new camera that work correctly, meaning a relatively simple if phone == fairphone2; flip image condition would even yield false positives.

I’m much inclined to close here since I don’t think there is anything Conversations can do about this. This either seems to be a driver problem or something that could maybe be handled in libwebrtc. On that note; you might want to try the PlayStore version (or compile it yourself) because PlayStore is on a more recent version of libwebrtc. (Not that I have any reason to assume that this is in fact a bug that has been fixed in libwebrtc)

iNPUTmice avatar Aug 03 '20 18:08 iNPUTmice

I self-compiled Conversations using http://gultsch.de/files/libwebrtc-m84.aar, which doesn't help. I don't managed to self-compile libwebrtc yet. @iNPUTmice which versions ob libwebrtc are used in the F-Droid and PlayStore variants?

buggymonkey avatar Aug 05 '20 10:08 buggymonkey

I self-compiled Conversations using http://gultsch.de/files/libwebrtc-m84.aar, which doesn't help.

Ok. Thank you for checking.

I don't managed to self-compile libwebrtc yet.

I don’t think this will be necessary. It's unlikely to produce different results than using the precompiled m84

PlayStore is on m84. F-Droid is on m79

iNPUTmice avatar Aug 05 '20 10:08 iNPUTmice

I have the same issue.

I have a SAMSUNG S7 with LineageOS 14.1 withtout google service.

I can videocall a contact (android phone with google services) : the other contact receive the call + I can see the video source of my contact => the other doesn't listen to me , and don't see my video.

If i call an audio only call, same issue : the contact doesn't listen to me.

AND If I use firefox with a normal webrtc service, it works well with my LineageOS 14.1 withtout google service, the contact sees me and listen to me.

I hope you will find the issue, because it's very important to communicate with video conference in this time in 2020.

Question : the calls are encrypted? is not possible to add an encryption for the videos/audio calls?

Laughej12 avatar Aug 21 '20 21:08 Laughej12

@Laughej12 the Readme mentions the encryption

licaon-kter avatar Aug 21 '20 21:08 licaon-kter

@Laughej12 the Readme mentions the encryptione

Encrypted audio and video calls (DTLS-SRTP) ? yes but we can't configure it at all and we cant't be sure by a message (like in what's app), like it's really encrypted by srtp and dtls....

Laughej12 avatar Aug 21 '20 21:08 Laughej12

Not sure any of these apps give you such an option, it's always on.

Also, Conversations is open-source, you can actually verify this in the code, which can't be said for Whatsapp or the like.

licaon-kter avatar Aug 21 '20 21:08 licaon-kter

So, what do you think @iNPUTmice please ?

I have a samsung s7 with Lineageos 14.1 (android 7), without google apps. And a webrtc service on a website with my firefox browser on android lineageos works perfectly with both camera and audios full duplex.

more explanations here : https://github.com/iNPUTmice/Conversations/issues/3833#issuecomment-678509488

Thanks for your work, it's excellent.

Laughej12 avatar Aug 22 '20 16:08 Laughej12

Hey all,

'me too' (FP2, LineageOS 17.1 without blobbs) Conversations 2.9.2+fcr from F-Droid - I love it!)

Would it be an option to implement a setting to rotate the camera manually (this might cover some other use-cases as well)?

Thank you for all the effort you spent in this project also from my side!

LibrEars avatar Jan 02 '21 15:01 LibrEars

Here is the corresponding issue on Fairphone's bug tracker:

https://bugtracker.fairphone.com/project/fairphone-android-7/issue/167

qoheniac avatar Jan 16 '21 13:01 qoheniac

@qoheniac same for 2.9.4? F-Droid or Play?

licaon-kter avatar Jan 16 '21 15:01 licaon-kter

Quicksy 2.9.4 (F-Droid) Fairphone 2 (5 Mpx) Fairphone Open 19.12.1 (Android 7.1.2, Linux 3.4.0)

qoheniac avatar Jan 16 '21 15:01 qoheniac

FP2 with Fairphone 21.08.1 (Android 9) has the same problem (Conversations from f-droid)

wibrt avatar Nov 02 '21 13:11 wibrt

See also https://issuetracker.fairphone.com/products/fp2-a9/-/issues/21

qoheniac avatar Nov 02 '21 15:11 qoheniac

See also https://issuetracker.fairphone.com/products/fp2-a9/-/issues/21

info: i don't have this issue with the stock android camera app as described here

wibrt avatar Nov 02 '21 16:11 wibrt

That's because they fixed it there (see Karsten Tausche's reply to the second comment in the linked issue)

qoheniac avatar Nov 02 '21 16:11 qoheniac