phonebox_plugin icon indicating copy to clipboard operation
phonebox_plugin copied to clipboard

Release 0.0.11 - NetBox 4.2.x

Open cruse1977 opened this issue 9 months ago • 4 comments

This PR updates the plugin significantly.

  • v0.0.11 for NetBox 4.2.x support
  • Resolves a number of open issues
  • Implements a couple of requested features (Navigation + Optional Site on Number)
  • Removes legacy conditionals and standardises models
  • Standardises compatibility matrix on README
  • Converts to pyproject.toml away from setup.py

Tested against NetBox 4.2.3 (Docker)

cruse1977 avatar Feb 19 '25 00:02 cruse1977

Hey @cruse1977,

Thank you for the great PR!

I'm currently testing this in my dev environment. A few points I came across already:

  1. Dockerfile needs some minor fixes to build properly:
FROM netboxcommunity/netbox:latest

COPY ./phonebox_plugin /source/phonebox_plugin/phonebox_plugin/
COPY ./pyproject.toml /source/phonebox_plugin/
COPY ./MANIFEST.in /source/phonebox_plugin/
COPY ./README.md /source/phonebox_plugin/
RUN /usr/local/bin/uv pip install --no-cache-dir /source/phonebox_plugin/
  1. Could you make the Site field a multi-choice field? In many organizations, the Number-Site relation can be many-to-many. For example, a number could be received via both a SIP trunk in Site_DC1 and an E1 circuit in Site_DC2 in the same region.

iDebugAll avatar Feb 24 '25 19:02 iDebugAll

Sure, will do

cruse1977 avatar Feb 24 '25 21:02 cruse1977

any chance this will be merged soon?

jscooksey avatar May 01 '25 05:05 jscooksey

I too am wondering when we think this will be merged. Are there issues? How likely is it to be merged?

wallacj1899 avatar May 14 '25 01:05 wallacj1899