[BUG] Decode and build apk but crashed when launch it

[wangnianwu]

trafficstars

Information

1. Apktool Version (apktool -version) - latest
2. Operating System (Mac, Linux, Windows) - Mac
3. APK From? (Playstore, ROM, Other) - Other
4. Java Version (java --version) - java 11.0.16

Stacktrace/Logcat

Steps to Reproduce

1. apktool d and apktool b
2. install it by command line ('adb install')
3. launch it and crashed

Frameworks

If this APK is from an OEM ROM (Samsung, HTC, LG). Please attach framework files (.apks that live in /system/framework or /system/priv-app)

APK

If this APK can be freely shared, please upload/attach a link to it. app-debug.apk.zip please remove the suffix '.zip' from this file name, it's a demo apk.

Questions to ask before submission

1. Have you tried apktool d, apktool b without changing anything? yes
2. If you are trying to install a modified apk, did you resign it? yes, install it successfuly, but crashed when launch
3. Are you using the latest apktool version? yes, clone the latest source code and build it.

[iBotPeaches]

Well thats odd. If you use it with -s (without sources) does it work? It would suggest smali/baksmali is corrupting the file.

[wangnianwu]

yes, if I use it with -s and it work.

[wangnianwu]

Well thats odd. If you use it with -s (without sources) does it work? It would suggest smali/baksmali is corrupting the file.

@iBotPeaches has any new discoveries

[wangnianwu]

@iBotPeaches I have found that cause, here:

// In case we have no resources. We should store the minSdk we pulled from the source opcode api level
if (!mApkInfo.hasResources() && mMinSdkVersion > 0) {
    mApkInfo.setSdkInfoField("minSdkVersion", Integer.toString(mMinSdkVersion));
}

Add a condition likes:

// In case we have no resources. We should store the minSdk we pulled from the source opcode api level
if (!(mApkInfo.hasResources() && mConfig.forceDecodeManifest == Config.FORCE_DECODE_MANIFEST_FULL)
        && mMinSdkVersion > 0) {
    mApkInfo.setSdkInfoField("minSdkVersion", Integer.toString(mMinSdkVersion));
}

If not decode manifest, we can not get minSdkVersion. So build the dex with incorrect minSdkVersion(dex version).

[iBotPeaches]

@wangnianwu - You are welcome to open a PR with some reasoning. Its tough to follow samples in issues as it might not reflect the present state / context of code around it.