Apktool icon indicating copy to clipboard operation
Apktool copied to clipboard

build: build zip archive in parallel and in one pass

Open vbfox opened this issue 2 years ago • 2 comments
trafficstars

  • Use the apache compress library to zip in parallel
  • Avoid the temporary zip file and copy by adding the unknown files directly while building the apk

Notes:

  • It changes the exception types if one of the file is removed while we're generating the apk
  • It will conflict a bit with https://github.com/iBotPeaches/Apktool/pull/3410 i'll do the merge in one PR or the other if they are both accepted.

vbfox avatar Oct 31 '23 11:10 vbfox

We've had a pattern over the last decade of adding apache compress, ripping it back out and here we are adding it back. I do like this idea of further parallelization, but now that its merged my focus will be digging into the exact reasons we ripped out apache compress to remember if we are approaching a similar mistake.

If you are up to rebasing this to the newer parallelization model - I believe it should mostly work.

iBotPeaches avatar Dec 26 '23 11:12 iBotPeaches

  • Use the apache compress library to zip in parallel
  • Avoid the temporary zip file and copy by adding the unknown files directly while building the apk

Notes:

  • It changes the exception types if one of the file is removed while we're generating the apk
  • It will conflict a bit with https://github.com/iBotPeaches/Apktool/pull/3410 i'll do the merge in one PR or the other if they are both accepted.

Lesia-Angarsk avatar Apr 10 '24 14:04 Lesia-Angarsk