Hyprland icon indicating copy to clipboard operation
Hyprland copied to clipboard

adding version file for flake builds

Open luxus opened this issue 3 years ago • 9 comments

i would expect Hyprland --version would display the version (and last commit) but it shows me no error.. just the help

luxus avatar Aug 04 '22 19:08 luxus

hyprctl version??

vaxerski avatar Aug 04 '22 19:08 vaxerski

~~> hyprctl version Hyprland, built from branch at commit dirty (). flags: (if any) debug

i use the nixos flake so it should report 0.9.1?

luxus avatar Aug 04 '22 19:08 luxus

it reports nothing because you're building with meson and @fufexan has not yet added versioning for meson. It only works through CMake. Furthermore I think it's impossible to tell through the flake. Fufexan should know more.

vaxerski avatar Aug 04 '22 19:08 vaxerski

thanks for answering, i guessed it has todo with the manual build situation

luxus avatar Aug 04 '22 20:08 luxus

Versioning does work in meson as well since #321.

The problem here is that the flake has no way of determining that git info, since it strips out .git.

We should probably switch to using a version file which the flake and everything else can then check.

fufexan avatar Aug 04 '22 20:08 fufexan

if we have a version file we could update the version in the flake automaticly https://github.com/hyprwm/Hyprland/blob/3947fe9e9f8fb2912b969a20fbbec3f2ab62cef0/flake.nix#L36

luxus avatar Aug 04 '22 20:08 luxus

Speaking of that string, wasn't it supposed to be automatically updated?

viperML avatar Aug 04 '22 20:08 viperML

It was, but the GH runner doesn't get the git info properly and instead replaces the version with "". So I disabled it and then forgot about it.

fufexan avatar Aug 04 '22 20:08 fufexan

I'll try to make a release action with the actor set as Vaxry, that'll solve our problems.

fufexan avatar Aug 04 '22 20:08 fufexan

@fufexan any updates here or should I close this

vaxerski avatar Nov 19 '22 17:11 vaxerski

You can close it for now.

fufexan avatar Nov 19 '22 17:11 fufexan