hypertrace-ui icon indicating copy to clipboard operation
hypertrace-ui copied to clipboard

Bug: UI filter buttons in expanded view of Explorer results remove previously chosen filters

Open cseas opened this issue 3 years ago • 3 comments
trafficstars

Actual behaviour

Screenshot 2022-05-27 at 12 01 01 PM

When we add filters using the UI in Explorer page, they get added to the previously selected filters.

Screenshot 2022-05-27 at 12 21 58 PM

But when we select the filters from one of the attributes after expanding a search result, the filter removes all of the previously selected filters from the search bar.

Screenshot 2022-05-27 at 12 23 09 PM Screenshot 2022-05-27 at 12 23 35 PM

Expected behaviour

Filters from the expanded view of results should also be added to the existing filters instead of replacing them entirely.

cseas avatar May 27 '22 06:05 cseas

@anandtiwary @aaron-steinfeld @itssharmasandeep

cseas avatar Jul 18 '22 05:07 cseas

The filter in the top level explorer results works correctly because it is a filter-button that uses the addUrlFilter method.

The filter button in the expanded view of a result is buggy because it is instead a link that navigates to a URL with the new filter applied, completing wiping out any previously added filters.

cseas avatar Jul 26 '22 03:07 cseas

Same bug exists in the Services page:

Screenshot_2022-07-26_at_9_51_52_AM

And also the API Endpoints page:

Screenshot_2022-07-26_at_9_55_56_AM

#1766 fixes the bug at these places as well.

cseas avatar Jul 26 '22 04:07 cseas