hyperamp icon indicating copy to clipboard operation
hyperamp copied to clipboard

Published 20 hours ago • verified publisher icon hypermodules

Notifications

Open bcomnes opened this issue 8 years ago • 6 comments

When songs change, we should show a notification, preferably with the artwork or the app icon if its available.

bcomnes avatar Jun 29 '17 22:06 bcomnes

should be pretty easy, i've tooled around with the osx notifications api via electron before

ungoldman avatar Jun 29 '17 23:06 ungoldman

Maybe only when the window is closed.

bcomnes avatar Jun 29 '17 23:06 bcomnes

yeah would be nice to be able to toggle it too, getting song notifications when you're using another fullscreen app can be pretty annoying

ungoldman avatar Jun 29 '17 23:06 ungoldman

Some more things to think about for notification behavior https://electron.atom.io/docs/tutorial/notifications/#macos

ungoldman avatar Jul 01 '17 07:07 ungoldman

done:

  • [x] notifications

todo:

  • [ ] add pref to disable notifications to OS menu
  • [ ] add album art to notification
  • [ ] only notify if window is hidden or unfocused

ungoldman avatar Sep 17 '17 19:09 ungoldman

Updating the issue on this. I removed it from the a renderer with plans to move it to the main thread https://github.com/mikaelbr/node-notifier because the window process notifications didn't stack and were quite spammy in practice.

bcomnes avatar Oct 23 '17 01:10 bcomnes