firefly-tokens-erc20-erc721 icon indicating copy to clipboard operation
firefly-tokens-erc20-erc721 copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger

Add REST call and event batch size metrics

Open matthew1001 opened this issue 2 years ago • 2 comments
trafficstars

This PR adds a variety of metrics and will close https://github.com/hyperledger/firefly-tokens-erc20-erc721/issues/89 when its complete.

The approach I've used is to add to the existing log interceptor and use that as a point to capture inbound API metrics. The renamed logging-and-metrics interceptor exposes methods to set/inc/observe other metrics e.g. relating to blockchain calls and event processing.

A few more details of the approach I've used are in the issue.

matthew1001 avatar Apr 18 '23 14:04 matthew1001

@awrichar This has been open for a long time with lots of questions and lots of answers. What's the verdict? Are more changes requested, or are these changes approved and should be merged?

nguyer avatar Feb 15 '24 18:02 nguyer

@awrichar Could you have another pass at this PR and assess if any more changes needed?

EnriqueL8 avatar Apr 24 '24 10:04 EnriqueL8