fabric icon indicating copy to clipboard operation
fabric copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger

Update deploy_chaincode.md `package` command docs

Open curldapps2 opened this issue 3 years ago • 2 comments

Define the default behavior of peer lifecycle chaincode package, which does not include node_modules in the resulting tar.gz package for chaincode. The existing step of npm install and quote "If the command is successful, the JavaScript packages will be installed inside a node_modules folder. Now that we that have our dependencies, we can create the chaincode package." would lead a reader to believe that node_modules are included when they are not.

Also added more detail about what chaincode services allow node_modules when packaged manually.

Type of change

  • Bug fix
  • New feature
  • Improvement (improvement to code, performance, etc)
  • Test update
  • Documentation update

Description

Additional details

Related issues

curldapps2 avatar Jan 25 '22 18:01 curldapps2

Thank you for the contribution! Please sign the commit using the instructions at https://github.com/hyperledger/fabric/pull/3191/checks?check_run_id=4941497881

denyeart avatar Jan 26 '22 07:01 denyeart

@mbwhite Since we haven't received a signed commit yet, could you maybe move this one forward in a new PR? Take the inspiration from this PR and add any other clarifications that you think are needed...

denyeart avatar Sep 19 '22 15:09 denyeart

@curldapps2 thanks for your contribution, could you please take care of the DCO so that we can merge?

ale-linux avatar Oct 27 '22 09:10 ale-linux