besu
besu copied to clipboard
Retrieve all transaction receipts for a block in one request
Thanks for sending a pull request! Have you done the following?
- [x] Checked out our contribution guidelines?
- [x] Considered documentation and added the
doc-change-requiredlabel to this PR if updates are required. - [ ] Considered the changelog and included an update if required.
- [x] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests
Most advanced CI tests are deferred until PR approval, but you could:
- [ ] locally run all unit tests via:
./gradlew build - [ ] locally run all acceptance tests via:
./gradlew acceptanceTest - [ ] locally run all integration tests via:
./gradlew integrationTest - [ ] locally run all reference tests via:
./gradlew ethereum:referenceTests:referenceTests
PR description
- Retrieve all transaction receipts in a block in 1 call to blockchain query instead of a call for each transaction in a block
- Calculate transaction fee reward for miner based on
effectivePriorityFeePerGasinstead ofeffectiveGasPricebecausebaseFeewould be burnt.
My node on snap sync shows static block reward as 0 even at genesis block of ETH mainnet. Not sure if the protocol specification was purged as part of the state or simply a bug.
My node on snap sync shows static block reward as 0 even at genesis block of ETH mainnet. Not sure if the protocol specification was purged as part of the state or simply a bug.
is this comment related to this change or a separate issue?
My node on snap sync shows static block reward as 0 even at genesis block of ETH mainnet. Not sure if the protocol specification was purged as part of the state or simply a bug.
is this comment related to this change or a separate issue?
Separate issue. Incidentally discovered when testing the RPC method.
My node on snap sync shows static block reward as 0 even at genesis block of ETH mainnet. Not sure if the protocol specification was purged as part of the state or simply a bug.
is this comment related to this change or a separate issue?
Separate issue. Incidentally discovered when testing the RPC method.
ok - can you open an issue with more info if we need to look into it? thanks!
@wetitpig this PR needs updating with latest main - I don't have permission to update your branch