besu icon indicating copy to clipboard operation
besu copied to clipboard

Retrieve all transaction receipts for a block in one request

Open Wetitpig opened this issue 1 year ago • 9 comments
trafficstars

Thanks for sending a pull request! Have you done the following?

  • [x] Checked out our contribution guidelines?
  • [x] Considered documentation and added the doc-change-required label to this PR if updates are required.
  • [ ] Considered the changelog and included an update if required.
  • [x] For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Most advanced CI tests are deferred until PR approval, but you could:

  • [ ] locally run all unit tests via: ./gradlew build
  • [ ] locally run all acceptance tests via: ./gradlew acceptanceTest
  • [ ] locally run all integration tests via: ./gradlew integrationTest
  • [ ] locally run all reference tests via: ./gradlew ethereum:referenceTests:referenceTests

PR description

  1. Retrieve all transaction receipts in a block in 1 call to blockchain query instead of a call for each transaction in a block
  2. Calculate transaction fee reward for miner based on effectivePriorityFeePerGas instead of effectiveGasPrice because baseFee would be burnt.

Wetitpig avatar Feb 29 '24 13:02 Wetitpig

My node on snap sync shows static block reward as 0 even at genesis block of ETH mainnet. Not sure if the protocol specification was purged as part of the state or simply a bug.

Wetitpig avatar Feb 29 '24 17:02 Wetitpig

My node on snap sync shows static block reward as 0 even at genesis block of ETH mainnet. Not sure if the protocol specification was purged as part of the state or simply a bug.

is this comment related to this change or a separate issue?

macfarla avatar Mar 21 '24 01:03 macfarla

My node on snap sync shows static block reward as 0 even at genesis block of ETH mainnet. Not sure if the protocol specification was purged as part of the state or simply a bug.

is this comment related to this change or a separate issue?

Separate issue. Incidentally discovered when testing the RPC method.

Wetitpig avatar Mar 21 '24 02:03 Wetitpig

My node on snap sync shows static block reward as 0 even at genesis block of ETH mainnet. Not sure if the protocol specification was purged as part of the state or simply a bug.

is this comment related to this change or a separate issue?

Separate issue. Incidentally discovered when testing the RPC method.

ok - can you open an issue with more info if we need to look into it? thanks!

macfarla avatar Mar 21 '24 04:03 macfarla

@wetitpig this PR needs updating with latest main - I don't have permission to update your branch

macfarla avatar Mar 21 '24 04:03 macfarla