aries-framework-go icon indicating copy to clipboard operation
aries-framework-go copied to clipboard

Published 20 hours ago • verified publisher icon hyperledger-archives

Proposal: expose issuecredential eventProps publicly

Open borancar opened this issue 3 years ago • 1 comments

I believe there's value in exposing the eventProps publicly from issuecredential, especially when using the client interface. Consider that custom action handlers have no lib provided type-safe casts at the moment and have to get values out of the map for now. I'm discounting someone declaring the interface outside and relying on Go interface matching (cause this can get out of sync eventually).

The work itself would be very similar to https://github.com/hyperledger/aries-framework-go/blob/e05b76b09fcb32c95ff754a697ef361f9247d47f/pkg/didcomm/protocol/didexchange/event.go#L10

borancar avatar Aug 14 '22 21:08 borancar

@sudeshrshetty, happy to throw a PR, but what are your thoughts first? Or am I missing something very obvious?

borancar avatar Aug 14 '22 21:08 borancar