aries-framework-go icon indicating copy to clipboard operation
aries-framework-go copied to clipboard

DID Comm V2 - Incorrect controller data models

Open sudeshrshetty opened this issue 3 years ago • 2 comments

Due to recent updates in normalizing command controllers for DIDComm V1 & V2 support, command controller data models are not actually matching with the actual parameters a command controller is expecting.

  • https://github.com/hyperledger/aries-framework-go/blob/main/pkg/controller/command/vcwallet/models.go#L351
  • https://github.com/hyperledger/aries-framework-go/blob/main/pkg/controller/command/issuecredential/models.go#L76
  • there may be few more

sudeshrshetty avatar Dec 14 '21 15:12 sudeshrshetty

For example: even though a command controller function says it accepts GenericInvitation it actually accepts outofband.Invitation V1 or outofband.Invitation V2. Hard for clients to find out what to send as request.

sudeshrshetty avatar Dec 14 '21 15:12 sudeshrshetty

also, wallet users has to convert aries out of band invitation manually to generic invitation in order to use wallet. Need better design.

sudeshrshetty avatar Jan 05 '22 12:01 sudeshrshetty