hyperlane-monorepo
hyperlane-monorepo copied to clipboard
feat: Add block tag support in `reorgPeriod` parameter
Description
Allows setting an arbitrary string in reorgPeriod, which is used as a block tag to get the finalized block. Currently, only the Ethereum connector supports this feature with the following tags:
- finalized
- safe
- pending
- latest
- earliest
This is currently useful for EVM-compatible chains that don't have a fixed reorganization period, but instead rely on the block tag Finalized to indicate finality. For such chains, you should set reorgPeriod to finalized instead of a number of blocks.
Drive-by changes
Related issues
Backward compatibility
Yes
Testing
🦋 Changeset detected
Latest commit: 2442707c0675c4c1980088a7053d8dc147ff8533
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 9 packages
| Name | Type |
|---|---|
| @hyperlane-xyz/infra | Minor |
| @hyperlane-xyz/cli | Minor |
| @hyperlane-xyz/sdk | Minor |
| @hyperlane-xyz/helloworld | Minor |
| @hyperlane-xyz/widgets | Minor |
| @hyperlane-xyz/ccip-server | Minor |
| @hyperlane-xyz/github-proxy | Minor |
| @hyperlane-xyz/utils | Minor |
| @hyperlane-xyz/core | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 73.74%. Comparing base (
cd7a263) to head (2442707). Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #4629 +/- ##
=======================================
Coverage 73.74% 73.74%
=======================================
Files 100 100
Lines 1436 1436
Branches 187 187
=======================================
Hits 1059 1059
Misses 356 356
Partials 21 21
| Components | Coverage Δ | |
|---|---|---|
| core | 84.61% <ø> (ø) |
|
| hooks | 75.71% <ø> (ø) |
|
| isms | 77.58% <ø> (ø) |
|
| token | 88.75% <ø> (ø) |
|
| middlewares | 77.39% <ø> (ø) |
please run yarn changeset add to add a changeset :)
@apastushenka we're making a new release today so I'll merge the PR and get the remaining comment fixed in a follow up PR.
Really appreciate you making this contribution, especially since our requirements for this weren't very well defined. Thank you!