hyperlane-monorepo icon indicating copy to clipboard operation
hyperlane-monorepo copied to clipboard

fix(contracts): add `msg.Value` to `verifyMessageId`

Open aroralanuk opened this issue 1 year ago • 2 comments

Description

  • Added to the msg.value to verifyMessageId to test if the msgValue passed in is the same as the msgValue used postDispatch

Drive-by changes

  • None

Related issues

  • fixes https://github.com/chainlight-io/2024-08-hyperlane/issues/3

Backward compatibility

Yes

Testing

Unit tests

aroralanuk avatar Sep 20 '24 20:09 aroralanuk

🦋 Changeset detected

Latest commit: f4f638ef2d747debaf1de3ae3a303435ba272cf3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/core Minor
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch
@hyperlane-xyz/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 20 '24 20:09 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.27%. Comparing base (469f2f3) to head (f4f638e). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4541      +/-   ##
==========================================
+ Coverage   74.23%   74.27%   +0.03%     
==========================================
  Files         101      101              
  Lines        1479     1481       +2     
  Branches      191      192       +1     
==========================================
+ Hits         1098     1100       +2     
  Misses        360      360              
  Partials       21       21              
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 77.77% <ø> (ø)
isms 77.77% <57.14%> (+0.19%) :arrow_up:
token 89.01% <ø> (ø)
middlewares 77.58% <ø> (ø)

codecov[bot] avatar Sep 20 '24 20:09 codecov[bot]