hyperlane-monorepo icon indicating copy to clipboard operation
hyperlane-monorepo copied to clipboard

chore(sdk): add further zod support to SDK

Open nbayindirli opened this issue 1 year ago • 5 comments

Description

  • adds further zod support to SDK, namely for areas relating to transactions

Drive-by changes

  • No

Related issues

  • Fixes https://github.com/hyperlane-xyz/hyperlane-monorepo/issues/3740

Backward compatibility

  • Yes

Testing

  • None

nbayindirli avatar May 21 '24 22:05 nbayindirli

🦋 Changeset detected

Latest commit: b10b6d7ba42b574bb89b53351c81d91782075887

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/core Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 21 '24 22:05 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 63.96%. Comparing base (3dabcbd) to head (2c8b375).

Additional details and impacted files
@@           Coverage Diff            @@
##           cli-2.0    #3834   +/-   ##
========================================
  Coverage    63.96%   63.96%           
========================================
  Files          124      124           
  Lines         1543     1543           
  Branches       167      167           
========================================
  Hits           987      987           
  Misses         530      530           
  Partials        26       26           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 67.50% <ø> (ø)
isms 39.52% <ø> (ø)
token 65.41% <ø> (ø)
middlewares 77.05% <ø> (ø)

codecov[bot] avatar May 21 '24 22:05 codecov[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (cli-2.0@ee28c0e). Learn more about missing BASE report.

:exclamation: Current head ea71389 differs from pull request most recent head b10b6d7

Please upload reports for the commit b10b6d7 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             cli-2.0    #3834   +/-   ##
==========================================
  Coverage           ?   63.96%           
==========================================
  Files              ?      124           
  Lines              ?     1543           
  Branches           ?      167           
==========================================
  Hits               ?      987           
  Misses             ?      530           
  Partials           ?       26           
Components Coverage Δ
core 84.61% <0.00%> (?)
hooks 67.50% <0.00%> (?)
isms 39.52% <0.00%> (?)
token 65.41% <0.00%> (?)
middlewares 77.05% <0.00%> (?)

codecov-commenter avatar May 23 '24 19:05 codecov-commenter

Please add a changeset before merging

jmrossy avatar May 24 '24 14:05 jmrossy

would be great to have some super basic unit tests for your schemas

agreed– added here: https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/3834/commits/1181c63c63c659995bdd8c5ad38ccdd86aceda86

nbayindirli avatar May 24 '24 17:05 nbayindirli