hyper icon indicating copy to clipboard operation
hyper copied to clipboard

Add limited clippy to CI

Open seanmonstar opened this issue 3 years ago • 3 comments

Add a new job to CI, clippy, but that is extremely limited in what lints it checks for. Clippy's defaults are usually too annoying, but there a few specific things that I would like to catch in an automated fashion:

Add the job as a needs dependency of the ci-pass top-level job.

seanmonstar avatar Sep 07 '22 19:09 seanmonstar

Taking a look on this!

mastrzyz avatar Sep 13 '22 04:09 mastrzyz

Clippy's defaults are usually too annoying

@seanmonstar that's unfortunate to hear. Is there a specific lint that comes to mind, or is it the false positives in general?

dswij avatar Sep 21 '22 18:09 dswij

I was surprised to see hyper not utilizing clippy to it's fullest. I usually run projects with pedantic enabled, and it has been nothing but valuable to me.

I already saw hyper-utils having some clippy warnings, maybe it would be easier there, to keep it strict from the get-go?

tomkarw avatar Sep 21 '22 20:09 tomkarw