(feat) reenable benches/end_to_end.rs

[Robertoskr]

This benches were disabled becuase of the deprecation of Client and Server, this pr is to reenable them with the new conn aproach

[Robertoskr]

@seanmonstar @oddgrd Ready for review !

[oddgrd]

Hey, that's cool that you figured it out! I can have a look at this in the coming week, but I'm a new contributor myself so you'll have to wait for Sean to sign off on this whenever he has time. 🙂

[Robertoskr]

Hey Robertoskr. I had a look at this, and when I tried to run the benchmarks on your branch it seems some of the HTTP2 ones take quite long to finish. On my computer your branch took ~290 seconds to complete, but on the commit before these benchmarks were disabled they completed in ~80s. I left a couple of comments, but unfortunately I wasn't able to solve this myself so I can't be of much help here.

If you'd like you can have a look at my attempt, maybe it will help you. I was able to get it down to ~100s, but some of the HTTP2 benches are unstable. I might keep looking into this, if I figure it out I'll let you know. Good luck!

In my computer it runs the same as the previous version of them in 65 seconds

[oddgrd]

That's odd, because on my computer the http2 ones take a long time (the http1 ones run great):

[seanmonstar]

Thank you for tackling this issue! #3109 was just merged, which re-enables most of these benchmarks, so I'll close this one.