gobot icon indicating copy to clipboard operation
gobot copied to clipboard

Add diagonal hat directions to Xbox 360 joystick config

Open MrARM opened this issue 6 years ago • 2 comments
trafficstars

Diagonal directions are simply the 2 buttons hit added. Tested on a PowerA Xbox controller

MrARM avatar May 31 '19 04:05 MrARM

Codecov Report

Merging #672 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #672      +/-   ##
==========================================
- Coverage   77.29%   77.26%   -0.03%     
==========================================
  Files         158      158              
  Lines       10927    10927              
==========================================
- Hits         8446     8443       -3     
- Misses       2026     2028       +2     
- Partials      455      456       +1
Impacted Files Coverage Δ
platforms/particle/adaptor.go 87.24% <0%> (-2.02%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da10293...6d82d79. Read the comment docs.

codecov[bot] avatar May 31 '19 04:05 codecov[bot]

Hello @MrARM thanks for contributing to gobot.

Although I have no device to test this new feature, the new portion looks good to me and you have already tested it.

@deadprogram so IMO there is no problem to merge this PR except the (old, outdated?) CI check. Please could you have a look on it?

gen2thomas avatar Sep 19 '22 16:09 gen2thomas

LGTM, thanks @MrARM

deadprogram avatar Sep 25 '22 14:09 deadprogram