burp-flow icon indicating copy to clipboard operation
burp-flow copied to clipboard

Published 20 hours ago • verified publisher icon hvqzao

Time HH:MM:SS completely missing from the "Time" column

Open manuelbua opened this issue 5 years ago • 4 comments

I'm not sure this being it this way before me moving to macOS, but i now noticed the "Time" column is missing the time itself, only the date is present:

Screenshot 2020-02-04 at 22 07 42

manuelbua avatar Feb 04 '20 21:02 manuelbua

To add more information, i just found out that it seems related to the Burp Dark Theme, when switching to Nimbus for example, this doesn't happen:

Screenshot 2020-02-08 at 18 22 04

manuelbua avatar Feb 08 '20 17:02 manuelbua

I was able to reproduce the issue on dark theme. At the moment I don't really know how to approach this. Behavior of CellRenderer for Darcula theme is different than for remaining themes which means it either is Burp or Darcula itself is doing some strange things under the hood. I don't have much time to investigate it currently. I don't use dark theme so it has little to none priority to me. I highly encourage you to play with the plugin code and submit pull request to me once you will solve it!

hvqzao avatar Feb 09 '20 14:02 hvqzao

Unfortunately, this is back in Burp 2020.11.2 and 2020.11.3 with the new appearance system rollout. It now happens in both the Light and Dark themes.

jemjensen avatar Dec 02 '20 14:12 jemjensen

I think I just checked in a fix for this Time bug, a Dark mode bug (since the name is no longer "darkula" the old code was never triggering to change colors), and a javadoc build issue that was gumming up the builds. It should be in the "dark-mode-fixes" branch if I did it right. Admittedly, I'm not well-versed in git tho so if I need to do something else to get it checked in so I can initiate the pull request let me know.

jemjensen avatar Dec 02 '20 16:12 jemjensen