Stock-Prediction-Models icon indicating copy to clipboard operation
Stock-Prediction-Models copied to clipboard

Published 20 hours ago • verified publisher icon huseinzol05

Added automatic OHLCV fetcher for crypto exchanges

Open AlconDivino opened this issue 6 years ago • 6 comments

Added crypto_data_loader.py New Feature: fetch crypto data directly from exchange

AlconDivino avatar Mar 24 '19 16:03 AlconDivino

Added crypto_data_loader.py New Feature: fetch crypto data directly from exchange

I already did that too lol. Check to see which one is better.

bitnom avatar Mar 25 '19 18:03 bitnom

Added crypto_data_loader.py New Feature: fetch crypto data directly from exchange

Mine is slightly better. Please let mine get pulled this time so I can get on the contrib. It's this one https://github.com/huseinzol05/Stock-Prediction-Models/pull/11 for this file: https://github.com/TensorTom/Stock-Prediction-Models/blob/master/dataset/downloader_crypto.py

bitnom avatar Mar 25 '19 18:03 bitnom

Yeah just added the one directly to my evolution_bayesian.py file. My crypto loader passes the data as pandas.Dataframe directly to the script and not to a CSV file. Also my file is based on yours :D

AlconDivino avatar Mar 25 '19 18:03 AlconDivino

Yeah just added the one directly to my evolution_bayesian.py file. My crypto loader passes the data as pandas.Dataframe directly to the script and not to a CSV file. Also my file is based on yours :D

That's good. Just add an option so user can switch between your loader and flat csv so that my loader still works. It's good to have a CLI tool for it. Mine is an argv script.

bitnom avatar Mar 25 '19 18:03 bitnom

Yeah they just have to comment out 1 line and recommend the original one. No worries there

AlconDivino avatar Mar 25 '19 18:03 AlconDivino

Yeah they just have to comment out 1 line and recommend the original one. No worries there

Check my latest commits on my fork. Worked that out and also improved the structure.

bitnom avatar Mar 25 '19 20:03 bitnom